Skip to content

SNOW-3338458: Snowpark python support for WIF secret in EA#4202

Merged
sfc-gh-aling merged 6 commits into
mainfrom
tmehta-SNOW-3338458-snowpark-py-wif-changes
May 29, 2026
Merged

SNOW-3338458: Snowpark python support for WIF secret in EA#4202
sfc-gh-aling merged 6 commits into
mainfrom
tmehta-SNOW-3338458-snowpark-py-wif-changes

Conversation

@sfc-gh-tmehta

@sfc-gh-tmehta sfc-gh-tmehta commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-3338458

    Added the get_wif_token in the snowpark_python.
    Tested using stage import:
    Jenkin: https://snowpark-python-001.jenkinsdev1.us-west-2.aws-dev.app.snowflake.com/job/SnowparkPythonNoarchPackageBuilder/198529/

Sql:

snowpark_python_wif.sql

image

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@github-actions

github-actions Bot commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@codecov-commenter

codecov-commenter commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.39%. Comparing base (40c88b9) to head (a3595de).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4202   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         171      171           
  Lines       44233    44241    +8     
  Branches     7556     7556           
=======================================
+ Hits        42196    42204    +8     
  Misses       1250     1250           
  Partials      787      787

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-tmehta

sfc-gh-tmehta commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-tmehta sfc-gh-tmehta marked this pull request as ready for review May 6, 2026 22:54
@sfc-gh-tmehta sfc-gh-tmehta requested review from a team as code owners May 6, 2026 22:54
@sfc-gh-tmehta sfc-gh-tmehta force-pushed the tmehta-SNOW-3338458-snowpark-py-wif-changes branch 2 times, most recently from 8fb5c46 to 34e8045 Compare May 21, 2026 06:53
sfc-gh-mayliu
sfc-gh-mayliu reviewed May 21, 2026
View reviewed changes
Comment thread src/snowflake/snowpark/secrets.py
Comment thread tests/integ/conftest.py
Comment thread tests/integ/test_secrets.py Outdated
@sfc-gh-tmehta sfc-gh-tmehta force-pushed the tmehta-SNOW-3338458-snowpark-py-wif-changes branch from 34e8045 to febd04c Compare May 22, 2026 22:49
sfc-gh-mayliu
sfc-gh-mayliu approved these changes May 26, 2026
View reviewed changes
Comment thread src/snowflake/snowpark/secrets.py
sfc-gh-aling
sfc-gh-aling reviewed May 27, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
@sfc-gh-aling sfc-gh-aling merged commit dd9129f into main May 29, 2026
28 of 30 checks passed
@sfc-gh-aling sfc-gh-aling deleted the tmehta-SNOW-3338458-snowpark-py-wif-changes branch May 29, 2026 20:02
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-yuwang sfc-gh-yuwang sfc-gh-yuwang approved these changes

@sfc-gh-mayliu sfc-gh-mayliu sfc-gh-mayliu approved these changes

@sfc-gh-joshi sfc-gh-joshi Awaiting requested review from sfc-gh-joshi sfc-gh-joshi is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-nirsharma sfc-gh-nirsharma Awaiting requested review from sfc-gh-nirsharma

@sfc-gh-sxia sfc-gh-sxia Awaiting requested review from sfc-gh-sxia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-tmehta @codecov-commenter @sfc-gh-aling @sfc-gh-yuwang @sfc-gh-mayliu